scons: fix --gold-linker build after --as-needed
authorCiro Santilli <ciro.santilli@arm.com>
Wed, 15 Jan 2020 16:11:30 +0000 (16:11 +0000)
committerCiro Santilli <ciro.santilli@arm.com>
Wed, 22 Jan 2020 14:07:27 +0000 (14:07 +0000)
commitae7dd927e2978cee89d6828b31ab991aa6de40e2
treea2777be56d1253cba3ea73a88d0247c99124cd38
parent2f2f508c74b532ef4b9e083879a6c27b17e7bcb1
scons: fix --gold-linker build after --as-needed

The build was failing with:

/usr/bin/ld: unrecognized option '--as-needed -fuse-ld=gold'

and --verbose confirms that a single quoted CLI parameter was being
executed:

"-Wl,--as-needed -fuse-ld=gold"

This happened because at Ifb001786a66b0dd9b29865e39a5740313002f250
--as-needed was added, and because it is the second option to happen before
the following main.subst, it exposed the fact that the existing main.subst
was wrong, because it returns a string instead of the expected array.

Change-Id: I619d242d60fe9d27438638ac11c2b92512881f26
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/24624
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Gabe Black <gabeblack@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
SConstruct