Introduce in_inclusive_range, fix -Wtautological-compare warnings
authorSimon Marchi <simon.marchi@ericsson.com>
Mon, 30 Oct 2017 18:27:30 +0000 (14:27 -0400)
committerSimon Marchi <simon.marchi@ericsson.com>
Mon, 30 Oct 2017 18:27:38 +0000 (14:27 -0400)
commitb020ff8074af22639e3f3c0f700f45d067521249
tree52a5dcc3bd2b298e814b8f43c74d6aeac22edced
parent1b81856f5b00e7ba860e4de2f3a426f342327165
Introduce in_inclusive_range, fix -Wtautological-compare warnings

When compiling with clang or gcc 8, we see warnings like this:

/home/emaisin/src/binutils-gdb/gdb/arm-tdep.c:10013:13: error: comparison of 0 <= unsigned expression is always true [-Werror,-Wtautological-compare]
      if (0 <= insn_op1 && 3 >= insn_op1)
          ~ ^  ~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/arm-tdep.c:11722:20: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare]
      else if (opB >= 0 && opB <= 2)
               ~~~ ^  ~

This is because an unsigned integer (opB in this case) will always be >=
0.  It is still useful to keep both bounds of the range in the
expression, even if one is at the edge of the data type range.  This
patch introduces a utility function in_inclusive_range that gets rid of
the warning while conveying that we are checking for a range.

Tested by rebuilding.

gdb/ChangeLog:

* common/common-utils.h (in_inclusive_range): New function.
* arm-tdep.c (arm_record_extension_space): Use
in_inclusive_range.
(thumb_record_ld_st_reg_offset): Use in_inclusive_range.
* cris-tdep.c (cris_spec_reg_applicable): Use
in_inclusive_range.
gdb/ChangeLog
gdb/arm-tdep.c
gdb/common/common-utils.h
gdb/cris-tdep.c