projects / mesa.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 718b9f5) | patch
i965: fix 64-bit immediates in brw_inst(_set)_bits
authorConnor Abbott <connor.w.abbott@intel.com>
Mon, 3 Aug 2015 21:38:12 +0000 (14:38 -0700)
committerIago Toral Quiroga <itoral@igalia.com>
Mon, 23 Nov 2015 07:30:30 +0000 (08:30 +0100)
commitb1a83b5d1b677faf650a41cd2c152b4d1cd18f84
tree3315487b36ce2c84d4685608115f918771fcb7bctree
parent718b9f52dd9ba780decf5bb59f5100cf590393a0commit | diff
i965: fix 64-bit immediates in brw_inst(_set)_bits

If we tried to get/set something that was exactly 64 bits, we would
try to do (1 << 64) - 1 to calculate the mask which doesn't give us all
1's like we want.

v2 (Iago)
 - Replace ~0 by ~0ull
 - Removed unnecessary parenthesis

v3 (Kristian)
 - Avoid the conditional

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Kristian Høgsberg <krh@bitplanet.net>
src/mesa/drivers/dri/i965/brw_inst.h diff | blob | history