intel: tools: Fix aubinator_error's fprintf call (format-security)
authorKai Wasserbäch <kai@dev.carbon-project.org>
Sat, 25 Aug 2018 10:00:30 +0000 (12:00 +0200)
committerLionel Landwerlin <lionel.g.landwerlin@intel.com>
Sat, 25 Aug 2018 15:52:12 +0000 (16:52 +0100)
commitb2313ef4a887e11b2008f9109e3741b7def88370
tree802f06f257f779807841ea25f5696713e2dd2a66
parent70de31d0c106f58d6b7e6d5b79b8d90c1c112a3b
intel: tools: Fix aubinator_error's fprintf call (format-security)

The recent commit 4616639b49b4bbc91e503c1c27632dccc1c2b5be introduced
the new function aubinator_error() which is a trivial wrapper around
fprintf() to STDERR. The call to fprintf() however is passed the message
msg directly:
  fprintf(stderr, msg);

This is a format-security violation and leads to an FTBFS with
-Werror=format-security (GCC 8):
  ../../../src/intel/tools/aubinator.c: In function 'aubinator_error':
  ../../../src/intel/tools/aubinator.c:74:4: error: format not a string literal and no format arguments [-Werror=format-security]
      fprintf(stderr, msg);
      ^~~~~~~

This patch fixes this trivially by introducing a catch-all "%s" format
argument.

Fixes: 4616639b49b ("intel: tools: split aub parsing from aubinator")
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Kai Wasserbäch <kai@dev.carbon-project.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
src/intel/tools/aubinator.c