i965: Disable compaction for EOT send messages
authorBen Widawsky <benjamin.widawsky@intel.com>
Thu, 28 May 2015 00:55:02 +0000 (17:55 -0700)
committerBen Widawsky <benjamin.widawsky@intel.com>
Fri, 29 May 2015 18:55:10 +0000 (11:55 -0700)
commitb307921c3ff3b36607752f881a180272366a79cf
treee1e4d0a42014270d35d4e5f112bc6485594c24ab
parentc0d2b83f0bb15c1a10e53ef85c167febf699921a
i965: Disable compaction for EOT send messages

AFAICT, there is no real way to make sure a send message with EOT is properly
ignored from compact, nor can I see a way to actually encode EOT while
compacting. Before the single send optimization we'd always bail because we hit
the is_immediate && !is_compactable_immediate case. However, with single send,
is_immediate is not true, and so we end up trying to compact the un-compactible.

Without this, any compacting single send instruction will hang because the EOT
isn't there. I am not sure how I didn't hit this when I originally enabled the
optimization.  I didn't check if some surrounding code changed.

I know Neil and Matt were both looking into this. I did a quick search and
didn't see any patches out there to handle this. Please ignore if this has
already been sent by someone. (Direct me to it and I will review it).

Reported-by: Neil Roberts <neil@linux.intel.com>
Reported-by: Mark Janes <mark.a.janes@intel.com>
Tested-by: Mark Janes <mark.a.janes@intel.com>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Matt Turner <mattst88@gmail.com>
src/mesa/drivers/dri/i965/brw_eu_compact.c