GDB: Fix detection of ELF support when configuring with -Werror=implicit-function...
authorAlex Richardson <Alexander.Richardson@cl.cam.ac.uk>
Sat, 28 Nov 2020 16:45:06 +0000 (11:45 -0500)
committerSimon Marchi <simon.marchi@polymtl.ca>
Sat, 28 Nov 2020 16:45:16 +0000 (11:45 -0500)
commitb413232211bf7c7754095b017f27774d70646489
tree751c3ab403e7ce9605c979d91269f51cf4ec7d00
parent8d748d1dc56406228c2c76de2563859213364cbf
GDB: Fix detection of ELF support when configuring with -Werror=implicit-function-declaration

I am getting

    I'm sorry, Dave, I can't do that.  Symbol format `elf64-littleriscv' unknown.

errors after updating from GDB 8.3 to 10.  Bisecting showed that since
commit 1ff6de031241 ("bfd, ld: add CTF section linking"), bfd.h depends
on strncmp() being present, so configuring with
-Werror=implicit-function-declaration results in the check for ELF
support in BFD failing:

    .../gdb/gdb/../bfd/elf-bfd.h: In function 'bfd_section_is_ctf':
    .../gdb/gdb/../bfd/elf-bfd.h:3086:10: error: implicit declaration of function 'strncmp' [-Werror=implicit-function-declaration]
       return strncmp (name, ".ctf", 4) == 0 && (name[4] == 0 || name[4] == '.');

gdb/ChangeLog:

* acincludde.m4 (GDB_AC_CHECK_BFD): Include string.h in the test
program.

Change-Id: Iec5e21d454c2a544c44d65e23cfde552c424c18e
gdb/ChangeLog
gdb/acinclude.m4
gdb/configure