Create new common/pathstuff.[ch]
authorSergio Durigan Junior <sergiodj@redhat.com>
Fri, 9 Feb 2018 23:44:59 +0000 (18:44 -0500)
committerSergio Durigan Junior <sergiodj@redhat.com>
Wed, 28 Feb 2018 16:34:39 +0000 (11:34 -0500)
commitb4987c956dfa44ca9fd8552f63e15f5fa094b2a4
treeeb5a8f104fb0e220debf39ca6e9dc120ab93a8b7
parent3083294d65393a31522586e058500f6abda29b83
Create new common/pathstuff.[ch]

This commit moves the path manipulation routines found on utils.c to a
new common/pathstuff.c, and updates the Makefile.in's accordingly.
The routines moved are "gdb_realpath", "gdb_realpath_keepfile" and
"gdb_abspath".

This will be needed because gdbserver will have to call "gdb_abspath"
on my next patch, which implements a way to expand the path of the
inferior provided by the user in order to allow specifying just the
binary name when starting gdbserver, like:

  $ gdbserver :1234 a.out

With the recent addition of the startup-with-shell feature on
gdbserver, this scenario doesn't work anymore if the user doesn't have
the current directory listed in the PATH variable.

I had to do a minor adjustment on "gdb_abspath" because we don't have
access to "tilde_expand" on gdbserver, so now the function is using
"gdb_tilde_expand" instead.  Otherwise, the code is the same.

Regression tested on the BuildBot, without regressions.

gdb/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

* Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
(HFILES_NO_SRCDIR): Add "common/pathstuff.h".
* auto-load.c: Include "common/pathstuff.h".
* common/common-def.h (current_directory): Move here.
* common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
function.
* common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
prototype.
* common/pathstuff.c: New file.
* common/pathstuff.h: New file.
* compile/compile.c: Include "common/pathstuff.h".
* defs.h (current_directory): Move to "common/common-defs.h".
* dwarf2read.c: Include "common/pathstuff.h".
* exec.c: Likewise.
* guile/scm-safe-call.c: Likewise.
* linux-thread-db.c: Likewise.
* main.c: Likewise.
* nto-tdep.c: Likewise.
* objfiles.c: Likewise.
* source.c: Likewise.
* symtab.c: Likewise.
* utils.c: Include "common/pathstuff.h".
(gdb_realpath): Move to "common/pathstuff.c".
(gdb_realpath_keepfile): Likewise.
(gdb_abspath): Likewise.
* utils.h (gdb_realpath): Move to "common/pathstuff.h".
(gdb_realpath_keepfile): Likewise.
(gdb_abspath): Likewise.

gdb/gdbserver/ChangeLog:
2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>

* Makefile.in (SFILES): Add "$(srcdir)/common/pathstuff.c".
(OBJS): Add "pathstuff.o".
* server.c (current_directory): New global variable.
(captured_main): Initialize "current_directory".
24 files changed:
gdb/ChangeLog
gdb/Makefile.in
gdb/auto-load.c
gdb/common/common-defs.h
gdb/common/gdb_tilde_expand.c
gdb/common/gdb_tilde_expand.h
gdb/common/pathstuff.c [new file with mode: 0644]
gdb/common/pathstuff.h [new file with mode: 0644]
gdb/compile/compile.c
gdb/defs.h
gdb/dwarf2read.c
gdb/exec.c
gdb/gdbserver/ChangeLog
gdb/gdbserver/Makefile.in
gdb/gdbserver/server.c
gdb/guile/scm-safe-call.c
gdb/linux-thread-db.c
gdb/main.c
gdb/nto-tdep.c
gdb/objfiles.c
gdb/source.c
gdb/symtab.c
gdb/utils.c
gdb/utils.h