Add non-emptiness to conclusion of positive RE star unfolding. (#4899)
authorAndrew Reynolds <andrew.j.reynolds@gmail.com>
Sun, 16 Aug 2020 12:17:53 +0000 (07:17 -0500)
committerGitHub <noreply@github.com>
Sun, 16 Aug 2020 12:17:53 +0000 (07:17 -0500)
commitb4ae9cc5fd26ecbb51870020d05c427fc97c7103
treeddc520a2be8d099aa395b87ca0184e5149e34dfa
parentf4f7f148082535c23e24a0b92cdf2612f0598072
Add non-emptiness to conclusion of positive RE star unfolding. (#4899)

A recent commit (77e9881) simplified the form of the conclusion in regular expression star unfolding for the sake of uniformity in our internal proof calculus. However, this led to a noticeable drop in performance on a few specific RE benchmarks (the Norn set). This preserves the old behavior by extending the core rule for RE unfolding.

It also makes one minor change to the strings proof checker carried over from the proof-new branch.
src/theory/strings/proof_checker.cpp
src/theory/strings/regexp_operation.cpp
src/theory/strings/regexp_operation.h