Eliminate procfs.c:procfs_use_watchpoints
authorPedro Alves <palves@redhat.com>
Wed, 2 May 2018 23:37:07 +0000 (00:37 +0100)
committerPedro Alves <palves@redhat.com>
Wed, 2 May 2018 23:37:07 +0000 (00:37 +0100)
commitb5c8fcb1b40a61be5015b02e8cf456a56c258b5d
treee03ca76c9653aaf7e236e4f3efc74696124ff72d
parent77d3c63b0dc9d275a87d4ea2191ebd3830f6ca4a
Eliminate procfs.c:procfs_use_watchpoints

Now that procfs.c is only ever used by Solaris, and, both x86 and
SPARC Solaris support watchpoints (*), we don't need the separate
procfs_use_watchpoints function.  Getting rid of it simplifies
C++ification of target_ops.

(*) and I assume that any other Solaris port would use the same kernel
debug API interfaces for watchpoints.  Otherwise, we can worry about
it if it ever happens.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

* procfs.c (procfs_stopped_by_watchpoint)
(procfs_insert_watchpoint, procfs_remove_watchpoint)
(procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
Forward declare.
(procfs_use_watchpoints): Delete, move contents...
(procfs_target): ... here.
* procfs.h (procfs_use_watchpoints): Delete declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
procfs_use_watchpoints.
* sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
procfs_use_watchpoints.
gdb/ChangeLog
gdb/i386-sol2-nat.c
gdb/procfs.c
gdb/procfs.h
gdb/sparc-sol2-nat.c