Make host_address_to_string/gdb_print_host_address cast parameter to 'void *'
authorPedro Alves <palves@redhat.com>
Tue, 27 Oct 2015 17:25:09 +0000 (17:25 +0000)
committerPedro Alves <palves@redhat.com>
Tue, 27 Oct 2015 17:33:01 +0000 (17:33 +0000)
commitb80c3053162ec5533e120ee4e4ed30296d4c5fb2
treed9ee9703b487e999a1f3c4d47fbf756bd6cec9d0
parentd09f2c3fc15dd4491e9cfa455191045c0729a3c3
Make host_address_to_string/gdb_print_host_address cast parameter to 'void *'

Fixes a set of errors like:

 ../../src/gdb/symfile-debug.c: In function ‘int debug_qf_map_symtabs_matching_filename(objfile*, const char*, const char*, int (*)(symtab*, void*), void*)’:
 ../../src/gdb/symfile-debug.c:137:39: error: invalid conversion from ‘int (*)(symtab*, void*)’ to ‘const void*’ [-fpermissive]
host_address_to_string (callback),
^

Note this has to work with data and function pointers.  In C++11 we
may perhaps do something a bit safer, but we're not there yet, and I
don't think it really matters.  For now just always do a simple
C-style cast in host_address_to_string itself.  No point in adding a
void * cast to each and every caller.

gdb/ChangeLog:
2015-10-27  Pedro Alves  <palves@redhat.com>

* common/print-utils.c (host_address_to_string): Rename to ...
(host_address_to_string_1): ... this.
* common/print-utils.h (host_address_to_string): Reimplement as
wrapper around host_address_to_string_1.
* utils.c (gdb_print_host_address): Rename to ...
(gdb_print_host_address_1): ... this.
* utils.h (gdb_print_host_address): Reimplement as wrapper macro
around host_address_to_string_1.
gdb/ChangeLog
gdb/common/print-utils.c
gdb/common/print-utils.h
gdb/utils.c
gdb/utils.h