radv: fix issue with multisample positions and interp_var_at_sample.
authorDave Airlie <airlied@redhat.com>
Thu, 21 Dec 2017 04:03:20 +0000 (14:03 +1000)
committerDave Airlie <airlied@redhat.com>
Thu, 21 Dec 2017 19:42:48 +0000 (05:42 +1000)
commitb81f1a592b02d3d1928ab232c97675b12cad19fc
treeb7ed444922e97414e37e965eda01191f32aa05fe
parentbe86e5e7d553a3495aa44bc8393baa3bfdaa313d
radv: fix issue with multisample positions and interp_var_at_sample.

This fixes vmfaults seen on vega with:
dEQP-VK.pipeline.multisample_interpolation.sample_interpolate_at_single_sample_.128_128_1.samples_1

These were caused by the don't allocate cmask but it was just accidental.

The actual problem was the shader was trying to get the sample positions from
a buffer, but the buffer was never getting configured to contain them, as the
previous shader never needed them.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Fixes: 1171b304f3 (radv: overhaul fragment shader sample positions.)
Signed-off-by: Dave Airlie <airlied@redhat.com>
src/amd/vulkan/radv_cmd_buffer.c