i965: Initialize inout_offset parameter to brw_search_cache().
authorPaul Berry <stereotype441@gmail.com>
Wed, 24 Jul 2013 16:24:51 +0000 (09:24 -0700)
committerPaul Berry <stereotype441@gmail.com>
Thu, 25 Jul 2013 16:36:15 +0000 (09:36 -0700)
commitb8f13fbb856534cbc1345325b74ec47711493dd6
treeb055e41f9681d2a70f608f65791635af74e22a35
parent42a921fa92fae8fb8692e7c65c61235588385b3e
i965: Initialize inout_offset parameter to brw_search_cache().

Two callers of brw_search_cache() weren't initializing that function's
inout_offset parameter: brw_blorp_const_color_params::get_wm_prog()
and brw_blorp_const_color_params::get_wm_prog().

That's a benign problem, since the only effect of not initializing
inout_offset prior to calling brw_search_cache() is that the bit
corresponding to cache_id in brw->state.dirty.cache may not be set
reliably.  This is ok, since the cache_id's used by
brw_blorp_const_color_params::get_wm_prog() and
brw_blorp_blit_params::get_wm_prog() (BRW_BLORP_CONST_COLOR_PROG and
BRW_BLORP_BLIT_PROG, respectively) correspond to dirty bits that are
not used.

However, failing to initialize this parameter causes valgrind to
complain.  So let's go ahead and fix it to reduce valgrind noise.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66779

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp