base: Do not treat addresses < 10 specially
authorBoris Shingarov <shingarov@labware.com>
Sun, 8 Mar 2020 19:46:05 +0000 (15:46 -0400)
committerBoris Shingarov <shingarov@gmail.com>
Wed, 18 Mar 2020 00:07:28 +0000 (00:07 +0000)
commitbdfbd9b9bcb0f963527fc96b18816fa834ef07f6
treeff174be1ec8581ec1588fd822897e2949487bf98
parente0937d94430dee9ed3274e0f862610fd22b7741c
base: Do not treat addresses < 10 specially

The RSP stub (base/remote_gdb.cc) treats virtual addresses below 0x000A as
meaning "the address used in the previous m-packet".  This leads to nasty
surprises, and is not justified by neither the RSP protocol documentation
nor other existing RSP implementations.

Jira Issue: https://gem5.atlassian.net/browse/GEM5-407

Change-Id: I5fccc10a58d9af856eeee6d45418905c0f47ffab
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/26605
Maintainer: Gabe Black <gabeblack@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Gabe Black <gabeblack@google.com>
src/base/remote_gdb.cc