Config.in files: add missing dependencies to toolchain option comments
authorThomas De Schampheleire <patrickdepinguin@gmail.com>
Thu, 7 Nov 2013 08:24:37 +0000 (09:24 +0100)
committerPeter Korsgaard <peter@korsgaard.com>
Sun, 10 Nov 2013 22:59:57 +0000 (23:59 +0100)
commitbe084204eb418243d287f16b80290e564411c507
treed0d78e130e4982ba90987e7bd1889701fc978dfc
parent3c33c11386240444c6fde0984f43c64f98ce516d
Config.in files: add missing dependencies to toolchain option comments

When a package A depends on config option B and toolchain option C, then
the comment that is given when C is not fulfilled should also depend on B.
For example:

config BR2_PACKAGE_A
depends on BR2_B
depends on BR2_LARGEFILE
depends on BR2_WCHAR

comment "A needs a toolchain w/ largefile, wchar"
depends on !BR2_LARGEFILE || !BR2_WCHAR

This comment should actually be:

comment "A needs a toolchain w/ largefile, wchar"
depends on BR2_B
depends on !BR2_LARGEFILE || !BR2_WCHAR

or if possible (typically when B is a package config option declared in that
same Config.in file):

if BR2_B

comment "A needs a toolchain w/ largefile, wchar"
depends on !BR2_LARGEFILE || !BR2_WCHAR

[other config options depending on B]

endif

Otherwise, the comment would be visible even though the other dependencies
are not met.

This patch adds such missing dependencies, and changes existing such
dependencies from
  depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC
to
  depends on BR2_BASE_DEP
  depends on !BR2_TOOLCHAIN_USES_GLIBC
so that (positive) base dependencies are separate from the (negative)
toolchain dependencies. This strategy makes it easier to write such comments
(because one can simply copy the base dependency from the actual package
config option), but also avoids complex and long boolean expressions.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 (untested)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
162 files changed:
fs/iso9660/Config.in
linux/Config.ext.in
package/a10disp/Config.in
package/aiccu/Config.in
package/aircrack-ng/Config.in
package/alsamixergui/Config.in
package/avahi/Config.in
package/bcusdk/Config.in
package/bind/Config.in
package/blackbox/Config.in
package/bluez_utils/Config.in
package/bmon/Config.in
package/bonnie/Config.in
package/bustle/Config.in
package/ccid/Config.in
package/cdrkit/Config.in
package/civetweb/Config.in
package/classpath/Config.in
package/connman/Config.in
package/conntrack-tools/Config.in
package/coreutils/Config.in
package/cryptsetup/Config.in
package/curlftpfs/Config.in
package/cvs/Config.in
package/czmq/Config.in
package/dbus-glib/Config.in
package/dbus-python/Config.in
package/dbus/Config.in
package/dmraid/Config.in
package/docker/Config.in
package/dropwatch/Config.in
package/dstat/Config.in
package/ebtables/Config.in
package/efl/libedbus/Config.in
package/enlightenment/Config.in
package/exfat/Config.in
package/fdk-aac/Config.in
package/filemq/Config.in
package/findutils/Config.in
package/flex/Config.in
package/fltk/Config.in
package/foomatic-filters/Config.in
package/freescale-imx/gpu-viv-bin-mx6q/Config.in
package/gawk/Config.in
package/gdb/Config.in
package/gesftpserver/Config.in
package/gettext/Config.in
package/git/Config.in
package/gmpc/Config.in
package/gob2/Config.in
package/gpsd/Config.in
package/gstreamer/gst-ffmpeg/Config.in
package/gtest/Config.in
package/gutenprint/Config.in
package/gvfs/Config.in
package/hiawatha/Config.in
package/hplip/Config.in
package/inotify-tools/Config.in
package/iperf/Config.in
package/jamvm/Config.in
package/kismet/Config.in
package/libdrm/Config.in
package/libedit/Config.in
package/libfslvpuwrap/Config.in
package/libfuse/Config.in
package/libgail/Config.in
package/libglade/Config.in
package/libgtk2/Config.in
package/libnspr/Config.in
package/libnss/Config.in
package/libtirpc/Config.in
package/libunwind/Config.in
package/liburcu/Config.in
package/linknx/Config.in
package/linphone/Config.in
package/lmbench/Config.in
package/logrotate/Config.in
package/ltp-testsuite/Config.in
package/lttng-babeltrace/Config.in
package/lttng-libust/Config.in
package/lttng-tools/Config.in
package/lvm2/Config.in
package/lxc/Config.in
package/lzma/Config.in
package/m4/Config.in
package/midori/Config.in
package/minicom/Config.in
package/minidlna/Config.in
package/mongoose/Config.in
package/mplayer/Config.in
package/mutt/Config.in
package/mysql_client/Config.in
package/ndisc6/Config.in
package/neard/Config.in
package/neardal/Config.in
package/netatalk/Config.in
package/netkitbase/Config.in
package/netkittelnet/Config.in
package/network-manager/Config.in
package/nfs-utils/Config.in
package/nmap/Config.in
package/nodejs/Config.in
package/ntfs-3g/Config.in
package/numactl/Config.in
package/ofono/Config.in
package/olsr/Config.in
package/on2-8170-modules/Config.in
package/openobex/Config.in
package/openpowerlink/Config.in
package/openvpn/Config.in
package/oprofile/Config.in
package/p11-kit/Config.in
package/parted/Config.in
package/pcmanfm/Config.in
package/pcsc-lite/Config.in
package/php/Config.ext
package/pkg-config/Config.in
package/python-nfc/Config.in
package/python-pyzmq/Config.in
package/python/Config.in
package/python3/Config.in
package/qt/Config.in
package/qt5/Config.in
package/quagga/Config.in
package/quota/Config.in
package/radvd/Config.in
package/redis/Config.in
package/rpcbind/Config.in
package/rpi-userland/Config.in
package/rt-tests/Config.in
package/rtorrent/Config.in
package/samba/Config.in
package/ser2net/Config.in
package/smartmontools/Config.in
package/snowball-init/Config.in
package/socat/Config.in
package/socketcand/Config.in
package/sqlcipher/Config.in
package/squashfs3/Config.in
package/squid/Config.in
package/sshfs/Config.in
package/synergy/Config.in
package/sysprof/Config.in
package/systemd/Config.in
package/transmission/Config.in
package/tvheadend/Config.in
package/udisks/Config.in
package/udpcast/Config.in
package/unionfs/Config.in
package/ussp-push/Config.in
package/vala/Config.in
package/webkit/Config.in
package/webrtc-audio-processing/Config.in
package/wget/Config.in
package/wireshark/Config.in
package/wvdial/Config.in
package/wvstreams/Config.in
package/xenomai/Config.in
package/xscreensaver/Config.in
package/zmqpp/Config.in
package/zyre/Config.in
system/Config.in