gdb: Override store_sym_names_in_linkage_form_p for Go language
authorAndrew Burgess <andrew.burgess@embecosm.com>
Wed, 8 Jul 2020 10:09:45 +0000 (11:09 +0100)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Wed, 16 Sep 2020 09:16:49 +0000 (10:16 +0100)
commitbf92aec5884b64a73a334aea875c68e8d1f959fc
tree16b06fd1fbadc8bddf2880b0c2f761a26c5a1ded
parentd3355e4dec4966ea32d47fc004e1bf8d9b3a3510
gdb: Override store_sym_names_in_linkage_form_p for Go language

When store_sym_names_in_linkage_form_p was introduced in this commit:

  commit 59cc4834e53565da1de4a7b615ed8890ed55c7da
  Date:   Tue Mar 27 08:57:16 2018 -0500

      problem looking up some symbols when they have a linkage name

A special case was left behind for Go, however, this special case was
not really needed anymore, it could be handled by having
store_sym_names_in_linkage_form_p return the true for go, instead of
false.

This commit overrides store_sym_names_in_linkage_form_p for Go, and
then removes the special case.  As store_sym_names_in_linkage_form_p
is only called once throughout GDB this should be perfectly safe.

There should be no user visible changes after this commit.

gdb/ChangeLog:

* dwarf2/read.c (dwarf2_physname): Remove special case for
language_go.
* go-lang.c (go_language::store_sym_names_in_linkage_form_p): New
member function.
gdb/ChangeLog
gdb/dwarf2/read.c
gdb/go-lang.c