drivers/meta: Accept GL_TEXTURE_3D as target for tex image decompression
authorEduardo Lima Mitev <elima@igalia.com>
Tue, 18 Oct 2016 07:55:38 +0000 (09:55 +0200)
committerKenneth Graunke <kenneth@whitecape.org>
Fri, 28 Oct 2016 07:20:32 +0000 (00:20 -0700)
commitc06480390b68c7118b0628f0a2702e6a8c67e1e0
treeeb5be5f9760089cb9cfd87220501f955396375b7
parent43dadb6edd5e3e3e10b1198184a9f75556edad49
drivers/meta: Accept GL_TEXTURE_3D as target for tex image decompression

An assert is currently raised, preventing decompression of a texture image into
a GL_TEXTURE_3D target. I have not found any spec wording that would explain
this, or implementation detail that would prevent it. And in any case, the
driver should not cause a crash upon user input arguments.

Fixes most failing subcases in CTS tests:
* GL44-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore
* GL45-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore

These tests were crashing the driver before. Now they just fail, but due
to an unrelated issue affecting 2 out of the 45 test subcases.

No regressions observed against piglit or CTS-GL.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/common/meta.c