gpu-compute: Fixing HSA's barrier bit implementation
authorSooraj Puthoor <Sooraj.Puthoor@amd.com>
Tue, 16 Jun 2020 01:48:15 +0000 (20:48 -0500)
committerMatt Sinclair <mattdsinclair@gmail.com>
Thu, 13 Aug 2020 02:08:27 +0000 (02:08 +0000)
commitc07a3548c4b74ce80672711b6ce436fb9c162a42
tree1ded562b4ef8b6c70866da146c1095e10701399b
parent96cac38b3bc8dbb9cefdb7ba2e19c6b45d4d4240
gpu-compute: Fixing HSA's barrier bit implementation

This changeset fixes several bugs in the HSA barrier bit implementation.

1. Forces AQL packet launch to wait for completion of all previous packets
2. Enforces barrier bit blocking only if there are packets pending completion
3. Barrier bit unblocking is correclty done by the last pending packet
4. Implementing barrier bit for all packets to conform to HSA spec

Change-Id: I62ce589dff57dcde4d64054a1b6ffd962acd5eb8
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30354
Reviewed-by: Sooraj Puthoor <puthoorsooraj@gmail.com>
Maintainer: Anthony Gutierrez <anthony.gutierrez@amd.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/dev/hsa/hsa_packet_processor.cc
src/dev/hsa/hsa_packet_processor.hh