compiler: fix double evaluation with interface field expression
authorIan Lance Taylor <ian@gcc.gnu.org>
Tue, 10 Jul 2018 00:55:28 +0000 (00:55 +0000)
committerIan Lance Taylor <ian@gcc.gnu.org>
Tue, 10 Jul 2018 00:55:28 +0000 (00:55 +0000)
commitc0cb9a9da0a7e257297deb25193cc9f113ee672a
tree26c3014d414d02aa217dd23af1afbe63837aa7f7
parentfd7ec17d0ba5bce1f71aff0d4ac80eb07121a1d3
compiler: fix double evaluation with interface field expression

    In Interface_field_reference_expression, the interface expression
    is used in two places, so a temporary variable is used. Previously,
    we used a Set_and_use_temporary_expression, which, when evaluated
    twice, causes double evaluation of the underlying expression. Fix
    by setting the temporary once and use Temporary_reference_expression
    instead.

    Fixes golang/go#26248.

    Reviewed-on: https://go-review.googlesource.com/122756

From-SVN: r262533
gcc/go/gofrontend/MERGE
gcc/go/gofrontend/expressions.cc