projects / mesa.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: bd6f0dc) | patch
mesa: Avoid out-of-bounds stack read via _mesa_Materiali
authorNicolai Hähnle <nicolai.haehnle@amd.com>
Wed, 22 Feb 2017 17:06:46 +0000 (18:06 +0100)
committerNicolai Hähnle <nicolai.haehnle@amd.com>
Wed, 22 Mar 2017 11:12:11 +0000 (12:12 +0100)
commitc2dfff280ba7d0857e350581496daa17cccacb84
tree80caf41ded73ad947cac1321c847b64879b39263tree
parentbd6f0dcafce73b1c7332a1c51f6862470fe2c2a0commit | diff
mesa: Avoid out-of-bounds stack read via _mesa_Materiali

MATERIALFV may end up reading up to 4 floats from the passed parameter.

This should really set a GL_INVALID_ENUM error in the cases where it
matters, but does anybody really care?

Found by ASAN in piglit gl-1.0-beginend-coverage.

v2: fix a trivial compiler warning

Reviewed-by: Marek Olšák <marek.olsak@amd.com> (v1)
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> (v1)
src/mesa/main/api_loopback.c diff | blob | history