base: Make the default checkBpLen method return true.
authorGabe Black <gabe.black@gmail.com>
Mon, 25 Jan 2021 06:38:40 +0000 (22:38 -0800)
committerGabe Black <gabe.black@gmail.com>
Wed, 27 Jan 2021 00:41:38 +0000 (00:41 +0000)
commitc4cad07fc524f7b1362ab98d66e961ad80a8587c
tree5e70b57fcffd6b4b9544596c03cc824f641adb18
parent0963d3ac8bf9beaea6ab5a7e48c187c24fbd8bb6
base: Make the default checkBpLen method return true.

This was checking that the breakpoint length was equal to the length of
the ISA specific MachInst type. Instead, force the ISA specific remote
GDB subclass to implement a check if it wants to, specific to its needs.
The base implementation will just approve of any length, which should be
fine with a well behaved GDB client.

Change-Id: Id7325b788f8445049855f8104082b8e4da1fe300
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39661
Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br>
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>
src/base/remote_gdb.cc