x86: Insert ENDBR if function will be called indirectly
authorH.J. Lu <hjl.tools@gmail.com>
Wed, 8 Apr 2020 16:47:35 +0000 (09:47 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Wed, 8 Apr 2020 16:47:53 +0000 (09:47 -0700)
commitc5f379653964a1d2c7037b2de3e947a48370a198
tree4c8c0f81228ae562527397802e41a9d0d02e4931
parent8bf5faa9c463f0d53ffe835ba03d4502edfb959d
x86: Insert ENDBR if function will be called indirectly

Since constant_call_address_operand has

;; Test for a pc-relative call operand
(define_predicate "constant_call_address_operand"
  (match_code "symbol_ref")
{
  if (ix86_cmodel == CM_LARGE || ix86_cmodel == CM_LARGE_PIC
      || flag_force_indirect_call)
    return false;
  if (TARGET_DLLIMPORT_DECL_ATTRIBUTES && SYMBOL_REF_DLLIMPORT_P (op))
    return false;
  return true;
})

even if cgraph_node::get (cfun->decl)->only_called_directly_p () returns
false, the fuction may still be called indirectly.  Copy the logic from
constant_call_address_operand to rest_of_insert_endbranch to insert ENDBR
at function entry if function will be called indirectly.

gcc/

PR target/94417
* config/i386/i386-features.c (rest_of_insert_endbranch): Insert
ENDBR at function entry if function will be called indirectly.

gcc/testsuite/

PR target/94417
* gcc.target/i386/pr94417-1.c: New test.
* gcc.target/i386/pr94417-2.c: Likewise.
* gcc.target/i386/pr94417-3.c: Likewise.
gcc/ChangeLog
gcc/config/i386/i386-features.c
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.target/i386/pr94417-1.c [new file with mode: 0644]
gcc/testsuite/gcc.target/i386/pr94417-2.c [new file with mode: 0644]
gcc/testsuite/gcc.target/i386/pr94417-3.c [new file with mode: 0644]