[gdb/tdep] Reset force_thumb in parse_arm_disassembler_options
authorTom de Vries <tdevries@suse.de>
Mon, 13 Sep 2021 18:16:36 +0000 (20:16 +0200)
committerTom de Vries <tdevries@suse.de>
Mon, 13 Sep 2021 18:16:36 +0000 (20:16 +0200)
commitcad152f2211282b938f11b021f2acf3df517557e
tree04f657bc8a3d0a66a0e5478454ed0147b1532b17
parente68b7db18cf127d054bebe9d6b28c0bfeadaf18a
[gdb/tdep] Reset force_thumb in parse_arm_disassembler_options

With a gdb build with --enable-targets=all, we have 2 arch-specific failures
in selftest print_one_insn:
...
$ gdb -q -batch a.out -ex "maint selftest print_one_insn" 2>&1 \
  | grep "Self test failed: arch "
Self test failed: arch armv8.1-m.main: self-test failed at \
  disasm-selftests.c:165
Self test failed: arch arm_any: self-test failed at disasm-selftests.c:165
$
...

During the first failed test, force_thumb is set to true, and remains so until
and during the second test, which causes the second failure.

Fix this by resetting force_thumb to false in parse_arm_disassembler_options,
such that we get just one failure:
...
$ gdb -q -batch a.out -ex "maint selftest print_one_insn" 2>&1 \
  | grep "Self test failed: arch "
Self test failed: arch armv8.1-m.main: self-test failed at \
  disasm-selftests.c:165
$
...

Tested on x86_64-linux.
opcodes/arm-dis.c