Fix PR16508
authorYao Qi <yao@codesourcery.com>
Sat, 15 Feb 2014 00:48:53 +0000 (08:48 +0800)
committerYao Qi <yao@codesourcery.com>
Thu, 6 Mar 2014 03:33:06 +0000 (11:33 +0800)
commitcc3da688013b5fb3dcc1fa5206bbeef4a35cc10c
tree8bccdf77f1d2543b5d3c7f658b9e4cf027cacd6c
parent6a5f844b29319793deb3840b20803bd3a0fa01a2
Fix PR16508

This patch fixes PR16508, which is about MI "-trace-find frame-number 0"
behaves differently from CLI "tfind 0".  In CLI, we check both
status->running and status->filename, but in MI, we only check
status->running, which looks wrong to me.  This patch moves the code
of checking to a new function check_trace_running, and use it in
both CLI and MI.

This patch also adds a test case pr16508.exp, which fails without this
fix, and passes with the fix applied.

  FAIL: gdb.trace/pr16508.exp: interpreter-exec mi "-trace-find frame-number 0"

gdb:

2014-03-06  Yao Qi  <yao@codesourcery.com>

PR breakpoints/16508
* tracepoint.c (check_trace_running): New function.
(trace_find_command): Move code to check_trace_running and
call check_trace_running.
(trace_find_pc_command): Likewise.
(trace_find_tracepoint_command): Likewise.
(trace_find_line_command): Likewise.
(trace_find_range_command): Likewise.
* tracepoint.h (check_trace_running): Likewise.
* mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running.

gdb/testsuite:

2014-03-06  Yao Qi  <yao@codesourcery.com>

* gdb.trace/pr16508.exp: New file.
gdb/ChangeLog
gdb/mi/mi-main.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.trace/pr16508.exp [new file with mode: 0644]
gdb/tracepoint.c
gdb/tracepoint.h