arm: Don't use pseudo instructions to implement regular instructions.
authorGabe Black <gabeblack@google.com>
Mon, 13 Apr 2020 05:05:00 +0000 (22:05 -0700)
committerGabe Black <gabeblack@google.com>
Wed, 8 Jul 2020 03:22:02 +0000 (03:22 +0000)
commitcc3e12b504c20b3bc78db52059d3f4f9b02dfbe8
tree81d7c028ced0ec3c376f796d6a0fade03d7932df
parent27e65633f117b655528bf56fb092b130dcdfcdbc
arm: Don't use pseudo instructions to implement regular instructions.

Some ARM instructions were using quiesce and quiesceSkip pseudo
instruction bodies instead of implementing the one line of each of those
functions themselves. This creates two problems. First, it adds an
artificial depedence on the pseudo instruction implementations. Second,
it would confusing cause pseudo instruction DPRINTFs to fire when normal
instructions were executing.

This change simply replaces the calls with their targets one line
implementation, with some very minor duplication from multiple call
sights factored out into a local variable.

Change-Id: I596eafd8714227fa7f69edd542108598c9809b11
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27790
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Maintainer: Giacomo Travaglini <giacomo.travaglini@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/arch/arm/isa/insts/misc.isa
src/arch/arm/isa/templates/pred.isa