Revert "mem-cache: Remove writebacks packet list"
authorDaniel Carvalho <odanrc@yahoo.com.br>
Sat, 1 Jun 2019 00:01:12 +0000 (00:01 +0000)
committerDaniel Carvalho <odanrc@yahoo.com.br>
Tue, 4 Jun 2019 22:28:41 +0000 (22:28 +0000)
commitcc6eff061c1b489c1a5f98d7fe5222837678ed2c
tree68040e97250162a8ef76631c984611fe786c9ae4
parentb68735f9fad5879e606849e78e1a4ad3f77f1463
Revert "mem-cache: Remove writebacks packet list"

This reverts commit bf0a722acdd8247602e83720a5f81a0b69c76250.

Reason for revert: This patch introduces a bug:

The problem here is that the insertion of block A may cause the
eviction of block B, which on the lower level may cause the
eviction of block A. Since A is not marked as present yet, A is
"safely" removed from the snoop filter

However, by reverting it, using atomic and a Tags sub-class that
can generate multiple evictions at once becomes broken when using
Atomic mode and shall be fixed in a future patch.

Change-Id: I5b27e54b54ae5b50255588835c1a2ebf3015f002
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/19088
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/mem/cache/base.cc
src/mem/cache/base.hh
src/mem/cache/cache.cc
src/mem/cache/cache.hh
src/mem/cache/noncoherent_cache.cc
src/mem/cache/noncoherent_cache.hh