common: Correct PBO 2D_ARRAY handling.
authorLaura Ekstrand <laura@jlekstrand.net>
Tue, 24 Feb 2015 22:51:29 +0000 (14:51 -0800)
committerLaura Ekstrand <laura@jlekstrand.net>
Wed, 25 Feb 2015 01:30:13 +0000 (17:30 -0800)
commitccc5ce6f72c1ec86be4dfcef96c0b51fba0faa6d
tree01c0ec242ff1a750c2bb08cc1da93b124df272b9
parent06084652fefe49c3d6bf1b476ff74ff602fdc22a
common: Correct PBO 2D_ARRAY handling.

Changes PBO uploads and downloads to use a tall (height * depth) 2D texture
for blitting. This fixes the bug where 2D_ARRAY, 3D, and CUBE_MAP_ARRAY
textures are not properly uploaded and downloaded.

Removes the option to use a 2D ARRAY texture for the PBO during upload and
download.  This option didn't work because the miptree couldn't be set up
reliably.

v2: Review from Jason Ekstrand and Neil Roberts:
   -Delete the depth parameter from create_texture_for_pbo
   -Abandon the option to create a 2D ARRAY texture in create_texture_for_pbo

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand@intel.com>
Cc: "10.4, 10.5" <mesa-stable@lists.freedesktop.org>
src/mesa/drivers/common/meta_tex_subimage.c