riscv: fix error on memory op address overflow
authorAlec Roelke <ar4jc@virginia.edu>
Tue, 21 Mar 2017 16:53:29 +0000 (12:53 -0400)
committerAlec Roelke <ar4jc@virginia.edu>
Wed, 5 Apr 2017 20:21:30 +0000 (20:21 +0000)
commitcd06bcf4ec2443eb719410e7e496e3d9d4d479c9
tree5a9e3d92c42be0c6ce77c06c83b1580c440e6ec3
parent9d0c9ab12361e009796bdb0b5d074c98d3f75b0e
riscv: fix error on memory op address overflow

Previously, if a memory operation referenced an address that caused the
data to wrap around to the beginning of the memory (such as -1 or
0xFFFFFFFFFFFFFFFF), an assert would fail during address translation and
gem5 would crash.  This patch fixes that by checking for such a case in
RISC-V's TLB code and returning a fault from translateData if that would
happen.  Because RISC-V does support unaligned memory accesses, no
checking is performed to make sure that an access doesn't cross a cache
line.

[Update creation of page table fault to use make_shared.]
[Add comment explaining the change and assertion that the memory request
isn't zero size.]

Change-Id: I7b8ef9a5838f30184dbdbd0c7c1655e1c04a9410
Reviewed-on: https://gem5-review.googlesource.com/2345
Maintainer: Alec Roelke <ar4jc@virginia.edu>
Reviewed-by: Brandon Potter <Brandon.Potter@amd.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
src/arch/riscv/tlb.cc