gdb/testsuite: fix "continue outside of loop" TCL errors
authorBruno Larsen <blarsen@redhat.com>
Fri, 13 May 2022 16:23:57 +0000 (13:23 -0300)
committerBruno Larsen <blarsen@redhat.com>
Mon, 16 May 2022 13:07:43 +0000 (10:07 -0300)
commitcdd4206647d0ef8d54d0fa66b3dfa57a4ec07db9
treebe9e3ffcbe58cd24f751c1c828a91b8b79099784
parentb7ff32f191ed7e708412e9faa31cf691f08ca695
gdb/testsuite: fix "continue outside of loop" TCL errors

Many test cases had a few lines in the beginning that look like:

if { condition } {
  continue
}

Where conditions varied, but were mostly in the form of ![runto_main] or
[skip_*_tests], making it quite clear that this code block was supposed
to finish the test if it entered the code block. This generates TCL
errors, as most of these tests are not inside loops.  All cases on which
this was an obvious mistake are changed in this patch.
298 files changed:
gdb/testsuite/gdb.ada/mi_ex_cond.exp
gdb/testsuite/gdb.ada/mi_task_arg.exp
gdb/testsuite/gdb.ada/mi_task_info.exp
gdb/testsuite/gdb.base/all-bin.exp
gdb/testsuite/gdb.base/arithmet.exp
gdb/testsuite/gdb.base/arrayidx.exp
gdb/testsuite/gdb.base/assign.exp
gdb/testsuite/gdb.base/async.exp
gdb/testsuite/gdb.base/attach-pie-misread.exp
gdb/testsuite/gdb.base/bfp-test.exp
gdb/testsuite/gdb.base/bitshift.exp
gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp
gdb/testsuite/gdb.base/branch-to-self.exp
gdb/testsuite/gdb.base/break-interp.exp
gdb/testsuite/gdb.base/call-ar-st.exp
gdb/testsuite/gdb.base/call-rt-st.exp
gdb/testsuite/gdb.base/call-sc.exp
gdb/testsuite/gdb.base/call-signal-resume.exp
gdb/testsuite/gdb.base/call-strs.exp
gdb/testsuite/gdb.base/callexit.exp
gdb/testsuite/gdb.base/callfuncs.exp
gdb/testsuite/gdb.base/cast-call.exp
gdb/testsuite/gdb.base/catch-fork-static.exp
gdb/testsuite/gdb.base/catch-signal-fork.exp
gdb/testsuite/gdb.base/catch-signal.exp
gdb/testsuite/gdb.base/checkpoint.exp
gdb/testsuite/gdb.base/cond-expr.exp
gdb/testsuite/gdb.base/consecutive.exp
gdb/testsuite/gdb.base/constvars.exp
gdb/testsuite/gdb.base/ctf-constvars.exp
gdb/testsuite/gdb.base/ctf-ptype.exp
gdb/testsuite/gdb.base/dfp-test.exp
gdb/testsuite/gdb.base/disasm-optim.exp
gdb/testsuite/gdb.base/enum_cond.exp
gdb/testsuite/gdb.base/eval-skip.exp
gdb/testsuite/gdb.base/exe-lock.exp
gdb/testsuite/gdb.base/exitsignal.exp
gdb/testsuite/gdb.base/exprs.exp
gdb/testsuite/gdb.base/fileio.exp
gdb/testsuite/gdb.base/float.exp
gdb/testsuite/gdb.base/float128.exp
gdb/testsuite/gdb.base/floatn.exp
gdb/testsuite/gdb.base/foll-exec-mode.exp
gdb/testsuite/gdb.base/foll-exec.exp
gdb/testsuite/gdb.base/gdb1250.exp
gdb/testsuite/gdb.base/gdb1821.exp
gdb/testsuite/gdb.base/infcall-input.exp
gdb/testsuite/gdb.base/inferior-died.exp
gdb/testsuite/gdb.base/interrupt-daemon-attach.exp
gdb/testsuite/gdb.base/interrupt.exp
gdb/testsuite/gdb.base/kill-after-signal.exp
gdb/testsuite/gdb.base/logical.exp
gdb/testsuite/gdb.base/miscexprs.exp
gdb/testsuite/gdb.base/multi-forks.exp
gdb/testsuite/gdb.base/nested-subp1.exp
gdb/testsuite/gdb.base/nested-subp2.exp
gdb/testsuite/gdb.base/nested-subp3.exp
gdb/testsuite/gdb.base/pc-fp.exp
gdb/testsuite/gdb.base/permissions.exp
gdb/testsuite/gdb.base/pie-execl.exp
gdb/testsuite/gdb.base/pointers.exp
gdb/testsuite/gdb.base/prologue.exp
gdb/testsuite/gdb.base/ptype.exp
gdb/testsuite/gdb.base/random-signal.exp
gdb/testsuite/gdb.base/readnever.exp
gdb/testsuite/gdb.base/relational.exp
gdb/testsuite/gdb.base/relativedebug.exp
gdb/testsuite/gdb.base/savedregs.exp
gdb/testsuite/gdb.base/setvar.exp
gdb/testsuite/gdb.base/sigall.exp
gdb/testsuite/gdb.base/sigaltstack.exp
gdb/testsuite/gdb.base/sigbpt.exp
gdb/testsuite/gdb.base/sigchld.exp
gdb/testsuite/gdb.base/siginfo-addr.exp
gdb/testsuite/gdb.base/siginfo-infcall.exp
gdb/testsuite/gdb.base/siginfo-obj.exp
gdb/testsuite/gdb.base/siginfo-thread.exp
gdb/testsuite/gdb.base/siginfo.exp
gdb/testsuite/gdb.base/signals.exp
gdb/testsuite/gdb.base/signull.exp
gdb/testsuite/gdb.base/sigrepeat.exp
gdb/testsuite/gdb.base/sigstep.exp
gdb/testsuite/gdb.base/sigwinch-notty.exp
gdb/testsuite/gdb.base/sizeof.exp
gdb/testsuite/gdb.base/skip-solib.exp
gdb/testsuite/gdb.base/store.exp
gdb/testsuite/gdb.base/structs.exp
gdb/testsuite/gdb.base/symbol-alias.exp
gdb/testsuite/gdb.base/unwindonsignal.exp
gdb/testsuite/gdb.base/varargs.exp
gdb/testsuite/gdb.base/volatile.exp
gdb/testsuite/gdb.base/whatis-exp.exp
gdb/testsuite/gdb.cp/ambiguous.exp
gdb/testsuite/gdb.cp/anon-ns.exp
gdb/testsuite/gdb.cp/bs15503.exp
gdb/testsuite/gdb.cp/casts.exp
gdb/testsuite/gdb.cp/class2.exp
gdb/testsuite/gdb.cp/constexpr-field.exp
gdb/testsuite/gdb.cp/converts.exp
gdb/testsuite/gdb.cp/cpsizeof.exp
gdb/testsuite/gdb.cp/ctti.exp
gdb/testsuite/gdb.cp/derivation.exp
gdb/testsuite/gdb.cp/disasm-func-name.exp
gdb/testsuite/gdb.cp/dispcxx.exp
gdb/testsuite/gdb.cp/exception.exp
gdb/testsuite/gdb.cp/filename.exp
gdb/testsuite/gdb.cp/fpointer.exp
gdb/testsuite/gdb.cp/gdb1355.exp
gdb/testsuite/gdb.cp/gdb2495.exp
gdb/testsuite/gdb.cp/impl-this.exp
gdb/testsuite/gdb.cp/iostream.exp
gdb/testsuite/gdb.cp/koenig.exp
gdb/testsuite/gdb.cp/local.exp
gdb/testsuite/gdb.cp/m-data.exp
gdb/testsuite/gdb.cp/m-static.exp
gdb/testsuite/gdb.cp/many-args.exp
gdb/testsuite/gdb.cp/mb-ctor.exp
gdb/testsuite/gdb.cp/member-ptr.exp
gdb/testsuite/gdb.cp/meth-typedefs.exp
gdb/testsuite/gdb.cp/method.exp
gdb/testsuite/gdb.cp/method2.exp
gdb/testsuite/gdb.cp/namelessclass.exp
gdb/testsuite/gdb.cp/namespace-nested-import.exp
gdb/testsuite/gdb.cp/namespace.exp
gdb/testsuite/gdb.cp/nextoverthrow.exp
gdb/testsuite/gdb.cp/nsalias.exp
gdb/testsuite/gdb.cp/nsdecl.exp
gdb/testsuite/gdb.cp/nsimport.exp
gdb/testsuite/gdb.cp/nsnested.exp
gdb/testsuite/gdb.cp/nsnoimports.exp
gdb/testsuite/gdb.cp/nsrecurs.exp
gdb/testsuite/gdb.cp/operator.exp
gdb/testsuite/gdb.cp/oranking.exp
gdb/testsuite/gdb.cp/ovldbreak.exp
gdb/testsuite/gdb.cp/ovsrch.exp
gdb/testsuite/gdb.cp/pass-by-ref-2.exp
gdb/testsuite/gdb.cp/pass-by-ref.exp
gdb/testsuite/gdb.cp/pr-1023.exp
gdb/testsuite/gdb.cp/pr-1210.exp
gdb/testsuite/gdb.cp/pr-574.exp
gdb/testsuite/gdb.cp/pr10728.exp
gdb/testsuite/gdb.cp/pr9067.exp
gdb/testsuite/gdb.cp/pr9631.exp
gdb/testsuite/gdb.cp/printmethod.exp
gdb/testsuite/gdb.cp/ref-types.exp
gdb/testsuite/gdb.cp/rtti.exp
gdb/testsuite/gdb.cp/rvalue-ref-sizeof.exp
gdb/testsuite/gdb.cp/rvalue-ref-types.exp
gdb/testsuite/gdb.cp/scope-err.exp
gdb/testsuite/gdb.cp/shadow.exp
gdb/testsuite/gdb.cp/smartp.exp
gdb/testsuite/gdb.cp/static-method.exp
gdb/testsuite/gdb.cp/temargs.exp
gdb/testsuite/gdb.cp/try_catch.exp
gdb/testsuite/gdb.cp/userdef.exp
gdb/testsuite/gdb.cp/var-tag.exp
gdb/testsuite/gdb.cp/virtbase.exp
gdb/testsuite/gdb.cp/virtbase2.exp
gdb/testsuite/gdb.cp/virtfunc2.exp
gdb/testsuite/gdb.cp/watch-cp.exp
gdb/testsuite/gdb.dwarf2/dw2-common-block.exp
gdb/testsuite/gdb.dwarf2/dw2-single-line-discriminators.exp
gdb/testsuite/gdb.dwarf2/implref-array.exp
gdb/testsuite/gdb.dwarf2/implref-const.exp
gdb/testsuite/gdb.dwarf2/implref-global.exp
gdb/testsuite/gdb.dwarf2/implref-struct.exp
gdb/testsuite/gdb.dwarf2/imported-unit.exp
gdb/testsuite/gdb.dwarf2/watch-notconst.exp
gdb/testsuite/gdb.fortran/array-bounds-high.exp
gdb/testsuite/gdb.fortran/array-bounds.exp
gdb/testsuite/gdb.fortran/array-element.exp
gdb/testsuite/gdb.fortran/array-indices.exp
gdb/testsuite/gdb.fortran/array-no-bounds.exp
gdb/testsuite/gdb.fortran/array-repeat.exp
gdb/testsuite/gdb.fortran/charset.exp
gdb/testsuite/gdb.fortran/common-block.exp
gdb/testsuite/gdb.fortran/complex.exp
gdb/testsuite/gdb.fortran/derived-type-function.exp
gdb/testsuite/gdb.fortran/derived-type-striding.exp
gdb/testsuite/gdb.fortran/derived-type.exp
gdb/testsuite/gdb.fortran/function-calls.exp
gdb/testsuite/gdb.fortran/info-modules.exp
gdb/testsuite/gdb.fortran/info-types.exp
gdb/testsuite/gdb.fortran/intrinsics.exp
gdb/testsuite/gdb.fortran/library-module.exp
gdb/testsuite/gdb.fortran/logical.exp
gdb/testsuite/gdb.fortran/max-depth.exp
gdb/testsuite/gdb.fortran/module.exp
gdb/testsuite/gdb.fortran/multi-dim.exp
gdb/testsuite/gdb.fortran/namelist.exp
gdb/testsuite/gdb.fortran/nested-funcs-2.exp
gdb/testsuite/gdb.fortran/print-formatted.exp
gdb/testsuite/gdb.fortran/ptype-on-functions.exp
gdb/testsuite/gdb.fortran/short-circuit-argument-list.exp
gdb/testsuite/gdb.fortran/subarray.exp
gdb/testsuite/gdb.fortran/vla-value.exp
gdb/testsuite/gdb.mi/dw2-ref-missing-frame.exp
gdb/testsuite/gdb.mi/gdb680.exp
gdb/testsuite/gdb.mi/list-thread-groups-available.exp
gdb/testsuite/gdb.mi/list-thread-groups-no-inferior.exp
gdb/testsuite/gdb.mi/mi-async-run.exp
gdb/testsuite/gdb.mi/mi-async.exp
gdb/testsuite/gdb.mi/mi-basics.exp
gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
gdb/testsuite/gdb.mi/mi-catch-cpp-exceptions.exp
gdb/testsuite/gdb.mi/mi-cmd-error.exp
gdb/testsuite/gdb.mi/mi-condbreak-call-thr-state.exp
gdb/testsuite/gdb.mi/mi-console.exp
gdb/testsuite/gdb.mi/mi-editing.exp
gdb/testsuite/gdb.mi/mi-eval.exp
gdb/testsuite/gdb.mi/mi-file-transfer.exp
gdb/testsuite/gdb.mi/mi-file.exp
gdb/testsuite/gdb.mi/mi-fullname-deleted.exp
gdb/testsuite/gdb.mi/mi-hack-cli.exp
gdb/testsuite/gdb.mi/mi-i-cmd.exp
gdb/testsuite/gdb.mi/mi-info-os.exp
gdb/testsuite/gdb.mi/mi-inheritance-syntax-error.exp
gdb/testsuite/gdb.mi/mi-language.exp
gdb/testsuite/gdb.mi/mi-linespec-err-cp.exp
gdb/testsuite/gdb.mi/mi-multi-commands.exp
gdb/testsuite/gdb.mi/mi-nonstop.exp
gdb/testsuite/gdb.mi/mi-ns-stale-regcache.exp
gdb/testsuite/gdb.mi/mi-nsintrall.exp
gdb/testsuite/gdb.mi/mi-nsmoribund.exp
gdb/testsuite/gdb.mi/mi-nsthrexec.exp
gdb/testsuite/gdb.mi/mi-pthreads.exp
gdb/testsuite/gdb.mi/mi-reg-undefined.exp
gdb/testsuite/gdb.mi/mi-return.exp
gdb/testsuite/gdb.mi/mi-simplerun.exp
gdb/testsuite/gdb.mi/mi-solib.exp
gdb/testsuite/gdb.mi/mi-stack.exp
gdb/testsuite/gdb.mi/mi-syn-frame.exp
gdb/testsuite/gdb.mi/mi-threads-interrupt.exp
gdb/testsuite/gdb.mi/mi-undefined-cmd.exp
gdb/testsuite/gdb.mi/mi-until.exp
gdb/testsuite/gdb.mi/mi-var-block.exp
gdb/testsuite/gdb.mi/mi-var-child-f.exp
gdb/testsuite/gdb.mi/mi-var-child.exp
gdb/testsuite/gdb.mi/mi-var-cmd.exp
gdb/testsuite/gdb.mi/mi-var-cp.exp
gdb/testsuite/gdb.mi/mi-var-display.exp
gdb/testsuite/gdb.mi/mi-var-invalidate.exp
gdb/testsuite/gdb.mi/mi-var-list-children-invalid-grandchild.exp
gdb/testsuite/gdb.mi/mi-var-rtti.exp
gdb/testsuite/gdb.mi/mi-vla-c99.exp
gdb/testsuite/gdb.mi/mi-vla-fortran.exp
gdb/testsuite/gdb.mi/mi-watch-nonstop.exp
gdb/testsuite/gdb.mi/mi2-amd64-entry-value.exp
gdb/testsuite/gdb.mi/mi2-cli-display.exp
gdb/testsuite/gdb.mi/mi2-prompt.exp
gdb/testsuite/gdb.mi/mi2-var-child.exp
gdb/testsuite/gdb.modula2/multidim.exp
gdb/testsuite/gdb.modula2/unbounded-array.exp
gdb/testsuite/gdb.multi/bkpt-multi-exec.exp
gdb/testsuite/gdb.opt/fortran-string.exp
gdb/testsuite/gdb.opt/inline-cmds.exp
gdb/testsuite/gdb.python/py-framefilter-mi.exp
gdb/testsuite/gdb.python/py-inferior-leak.exp
gdb/testsuite/gdb.python/py-mi-cmd.exp
gdb/testsuite/gdb.python/py-mi-events.exp
gdb/testsuite/gdb.python/py-mi-objfile.exp
gdb/testsuite/gdb.python/py-mi.exp
gdb/testsuite/gdb.reverse/ppc_record_test_isa_2_06.exp
gdb/testsuite/gdb.reverse/ppc_record_test_isa_3_1.exp
gdb/testsuite/gdb.rust/dwindex.exp
gdb/testsuite/gdb.rust/expr.exp
gdb/testsuite/gdb.rust/fnfield.exp
gdb/testsuite/gdb.rust/generics.exp
gdb/testsuite/gdb.rust/methods.exp
gdb/testsuite/gdb.rust/modules.exp
gdb/testsuite/gdb.rust/pp.exp
gdb/testsuite/gdb.rust/rawids.exp
gdb/testsuite/gdb.rust/rust-style.exp
gdb/testsuite/gdb.rust/simple.exp
gdb/testsuite/gdb.rust/traits.exp
gdb/testsuite/gdb.rust/unicode.exp
gdb/testsuite/gdb.rust/union.exp
gdb/testsuite/gdb.rust/unsized.exp
gdb/testsuite/gdb.rust/watch.exp
gdb/testsuite/gdb.server/extended-remote-restart.exp
gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
gdb/testsuite/gdb.stabs/exclfwd.exp
gdb/testsuite/gdb.threads/attach-into-signal.exp
gdb/testsuite/gdb.threads/attach-slow-waitpid.exp
gdb/testsuite/gdb.threads/attach-stopped.exp
gdb/testsuite/gdb.threads/check-libthread-db.exp
gdb/testsuite/gdb.threads/fork-plus-threads.exp
gdb/testsuite/gdb.threads/hand-call-in-threads.exp
gdb/testsuite/gdb.threads/hand-call-new-thread.exp
gdb/testsuite/gdb.threads/interrupted-hand-call.exp
gdb/testsuite/gdb.threads/names.exp
gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.exp
gdb/testsuite/gdb.threads/step-bg-decr-pc-switch-thread.exp
gdb/testsuite/gdb.threads/step-over-lands-on-breakpoint.exp
gdb/testsuite/gdb.threads/thread-unwindonsignal.exp
gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp
gdb/testsuite/gdb.trace/mi-tsv-changed.exp
gdb/testsuite/gdb.trace/stap-trace.exp