package/pkg-waf: properly escape HOST_DIR when defining <pkg>_WAF
authorThomas Petazzoni <thomas.petazzoni@bootlin.com>
Sun, 23 Sep 2018 13:38:17 +0000 (15:38 +0200)
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>
Tue, 25 Sep 2018 20:24:46 +0000 (22:24 +0200)
commitd1d2d0ac63cc1305a0c8264fd3f8c7605a8aeb8a
treed3d65979019994a26222d7fa7f297412d735afbe
parent81dddf29821cf1f7d90b96ad0739116f5c3bf1eb
package/pkg-waf: properly escape HOST_DIR when defining <pkg>_WAF

When <pkg>_NEEDS_EXTERNAL_WAF is set to YES, <pkg>_WAF is set to
$(HOST_DIR)/bin/waf within the inner-waf-package macro. This reference
to $(HOST_DIR) should use $$(HOST_DIR) so that it is properly expanded
at the time of use, and not at the time of the macro expansion.

In the current Buildroot, this doesn't cause any visible problem
because $(HOST_DIR) points to the same directory for all
packages. However, with per-package host/target directories, this is
no longer the case. It causes a build issue because it tries to use
"waf" from the global host directory, which doesn't exist during the
build.

This commit fixes the following build issue with per package
host/target directories:

/home/test/autobuild/run/instance-2/output/per-package/mpv/host/bin/python2: can't open file '/home/test/autobuild/run/instance-2/output/host/bin/waf': [Errno 2] No such file or directory
make: *** [/home/test/autobuild/run/instance-2/output/build/mpv-0.27.2/.stamp_configured] Error 2

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
package/pkg-waf.mk