aco: don't always add logical edges from continue_break blocks to headers
authorRhys Perry <pendingchaos02@gmail.com>
Tue, 7 Jan 2020 19:13:08 +0000 (19:13 +0000)
committerMarge Bot <eric+marge@anholt.net>
Wed, 29 Jan 2020 18:02:27 +0000 (18:02 +0000)
commitd282a292eca05bd9f701d8509d674e4697f510ec
tree1290d0df9b44e5edcf57aef4745dd3b2b9f77b06
parentdba71de5c63617677fe44558f995d35fad643413
aco: don't always add logical edges from continue_break blocks to headers

Otherwise, code like this will be broken:
loop {
   if (...) {
      break;
   } else {
      break;
   }
}
The continue_or_break block doesn't have any logical predecessors but it's
a logical predecessor of the header block. This liveness error breaks the
spiller in init_live_in_vars() (under "keep variables spilled on all
incoming paths") and eventually creates garbage reloads.

Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler')
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3257>
src/amd/compiler/aco_instruction_selection.cpp