Remove some ui_out-related cleanups from Python
authorTom Tromey <tom@tromey.com>
Wed, 11 Jan 2017 06:34:22 +0000 (23:34 -0700)
committerTom Tromey <tom@tromey.com>
Fri, 10 Feb 2017 19:24:31 +0000 (12:24 -0700)
commitd4b0bb186e204f77ed70bc719d16c6ca302094fd
treec919b755b87992476189da60f52abaab067d8907
parentf67f945cf2f6361d4c4997c487b174e396d23cd9
Remove some ui_out-related cleanups from Python

This patch introduces a bit of infrastructure -- namely, a minimal
std::optional analogue called gdb::optional, and an RAII template
class that works like make_cleanup_ui_out_tuple_begin_end or
make_cleanup_ui_out_list_begin_end -- and then uses these in the
Python code.  This removes a number of cleanups and generally
simplifies this code.

std::optional is only available in C++17.  Normally I would have had
this code check __cplusplus, but my gcc apparently isn't new enough to
find <optional>, even with -std=c++1z; so, because I could not test
it, the patch does not do this.

gdb/ChangeLog
2017-02-10  Tom Tromey  <tom@tromey.com>

* ui-out.h (ui_out_emit_type): New class.
(ui_out_emit_tuple, ui_out_emit_list): New typedefs.
* python/py-framefilter.c (py_print_single_arg): Use gdb::optional
and ui_out_emit_tuple.
(enumerate_locals): Likewise.
(py_mi_print_variables, py_print_locals, py_print_args): Use
ui_out_emit_list.
(py_print_frame): Use gdb::optional, ui_out_emit_tuple,
ui_out_emit_list.
* common/gdb_optional.h: New file.
gdb/ChangeLog
gdb/common/gdb_optional.h [new file with mode: 0644]
gdb/python/py-framefilter.c
gdb/ui-out.h