gas: equates of registers
authorJan Beulich <jbeulich@suse.com>
Fri, 12 May 2023 06:55:48 +0000 (08:55 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 12 May 2023 06:55:48 +0000 (08:55 +0200)
commitd50c498a1ba7249ccf1d429ce39ab247219c7205
treeba7648399a27de94117a511fe5fc8a82ece36e3f
parent8cea5fda33becb158c51a532e9281a7b17158459
gas: equates of registers

There are two problems: symbol_equated_p() doesn't recognize equates of
registers, and S_CAN_BE_REDEFINED() goes by section rather than by
expression type. Both together undermine .eqv and .equiv clearly meaning
to guard the involved symbols against re-definition (both ways).

To compensate pseudo_set() now using O_symbol and S_CAN_BE_REDEFINED()
now checking for O_register,
- for targets creating register symbols through symbol_{new,create}() ->
  symbol_init() -> S_SET_VALUE() (alpha, arc, dlx, ia64, m68k, mips,
  mmix, tic4x, tic54x, plus anything using cgen or itbl-ops), have
  symbol_init() set their expressions to O_register,
- x86'es parse_register() also can't go by section anymore when
  trying to "look through" equates; probably symbol_equated_p() should
  have been used there from the beginning, if only that had worked for
  equates of registers,
- various targets need to "look through" equates when parsing insn
  operands (which also helps transitive forward equates); perhaps even
  more ought to, but many don't look to consider the possibility of
  register equates in the first place.

This was uncovered by code reported in PR gas/30274 (duplicating
PR gas/30272), except that there .eqv was used when really .equ was
meant. Therefore that bug report is addressed here only in so far as
gas wouldn't crash anymore; the code there still won't assemble
successfully, just that now the issues there are properly diagnosed.
22 files changed:
gas/cgen.c
gas/config/tc-alpha.c
gas/config/tc-arc.c
gas/config/tc-dlx.c
gas/config/tc-i386.c
gas/config/tc-ia64.c
gas/config/tc-mmix.c
gas/config/tc-mn10200.c
gas/config/tc-mn10300.c
gas/config/tc-msp430.c
gas/config/tc-nds32.c
gas/config/tc-ppc.c
gas/config/tc-s390.c
gas/config/tc-spu.c
gas/config/tc-tic4x.c
gas/config/tc-v850.c
gas/config/tc-xgate.c
gas/config/tc-z80.c
gas/expr.c
gas/expr.h
gas/read.c
gas/symbols.c