Make sure that sorting does not change section order
authorPetr Tesarik <ptesarik@suse.cz>
Thu, 28 Jun 2018 06:32:27 +0000 (08:32 +0200)
committerPetr Tesarik <ptesarik@suse.cz>
Thu, 28 Jun 2018 06:35:34 +0000 (08:35 +0200)
commitd81a3eaff36b41ed67758a119a6864b50f60a60d
treee76d370a089eea74975ac1d92fdc91cc3dcdee50
parented6dfe517ee323ed631aa8b9816289ea35219409
Make sure that sorting does not change section order

Symbol files may contain multiple sections with the same name.
Section addresses specified by add-symbol-file are assigned to the
corresponding BFD sections in addr_info_make_relative using sorted
indexes of both vectors.  Since the sort algorithm is not inherently
stable, the comparison function uses sectindex to maintain the
original order.  However, add_symbol_file_command uses zero for all
sections, so if the user specifies multiple sections with the same
name, they will be assigned randomly to symbol file sections with
the same name.

gdb/ChangeLog:
2018-06-28  Petr Tesarik  <ptesarik@suse.cz>

* symfile.c (add_symbol_file_command): Make sure that sections
gdb/ChangeLog
gdb/symfile.c
gdb/symfile.h