Change ada_which_variant_applies to value API
authorTom Tromey <tromey@adacore.com>
Mon, 30 Mar 2020 17:50:35 +0000 (11:50 -0600)
committerTom Tromey <tromey@adacore.com>
Mon, 30 Mar 2020 17:54:50 +0000 (11:54 -0600)
commitd8af906814bd69dad694e475288401b1dee6ac3a
tree0e95af57f2a2ff0ca8fb515d6b12ff62c2d7498d
parent00386881a3d0f7ac89fcc5cc912da8cd69c04324
Change ada_which_variant_applies to value API

While debugging an Ada regression, I noticed that all the callers of
ada_which_variant_applies desconstruct a value, only to have it be
reconstructed by this function.

This patch removes this inefficiency in favor of simply passing in the
value directly.

Tested on x86-64 Fedora 30.

gdb/ChangeLog
2020-03-30  Tom Tromey  <tromey@adacore.com>

* ada-valprint.c (print_variant_part): Update.
* ada-lang.h (ada_which_variant_applies): Update.
* ada-lang.c (ada_which_variant_applies): Remove outer_type and
outer_valaddr parameters; replace with "outer" value parameter.
(to_fixed_variant_branch_type): Update.
gdb/ChangeLog
gdb/ada-lang.c
gdb/ada-lang.h
gdb/ada-valprint.c