libstdc++: Fix ambiguous comparisons in __gnu_debug::bitset [PR 96303]
authorJonathan Wakely <jwakely@redhat.com>
Fri, 7 Aug 2020 19:29:11 +0000 (20:29 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Fri, 7 Aug 2020 19:29:11 +0000 (20:29 +0100)
commitde1e3b8795e507c3cfa5b62984272628ca62a9bd
tree6f23a36ecf57b28a78f87cec837069e3eabe5147
parenta1ee6d507b0c26466be519d177f5a08b22f63647
libstdc++: Fix ambiguous comparisons in __gnu_debug::bitset [PR 96303]

With -pedantic the debug mode bitset has an ambiguous equality
comparison operator, because it tries to compare the non-debug base to
the debug object. The base object can be converted to another debug
bitset, making the same operator== a candidate again.

The fix is to do the comparison on both base objects, so the operator
for the derived type isn't a candidate.

For the inequality operator the same change should be done, but that
operator can be removed entirely for C++20 because it can be synthesized
by the compiler.

I don't think either equality or inequality operators are really needed,
because the public _GLIBCXX_STD_C::bitset base class cam always be
compared using its own comparison operators. I'm not changing that here
though.

libstdc++-v3/ChangeLog:

PR libstdc++/96303
* include/debug/bitset (bitset::operator==): Call _M_base() on
right operand.
(bitset::operator!=): Likewise, but don't define it at all when
default comparisons are supported by the compiler.
* testsuite/23_containers/bitset/operations/96303.cc: New test.
libstdc++-v3/include/debug/bitset
libstdc++-v3/testsuite/23_containers/bitset/operations/96303.cc [new file with mode: 0644]