cpu: Change how O3 handles requests for SMT in full system.
authorGabe Black <gabeblack@google.com>
Mon, 12 Oct 2020 00:19:51 +0000 (17:19 -0700)
committerGabe Black <gabeblack@google.com>
Tue, 13 Oct 2020 23:59:43 +0000 (23:59 +0000)
commitdf6269b63425d98a1c4ef289b41a09772b67d6f2
tree0a3b9aa24212090fad5c8f914c8e71f30f68bbf0
parent539247a4c76bc648e5128e5722935c8bdcb83d04
cpu: Change how O3 handles requests for SMT in full system.

Currently, when the numThreads parameter is set to something larger than
1 in full system mode, the O3 CPU will just silently change it back down
again to 1. This could be confusing to the user since it won't be
immediately apparent, even when looking at config.ini, that their config
isn't being respected.

This change moves that check into the CPU constructor, where CPU
behavior probably should be rather than the create() method which should
just build the object, and also turns it into an error.

Change-Id: I627ff8702b5e8aaad8839aa8d52524690be25619
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/35936
Reviewed-by: Gabe Black <gabeblack@google.com>
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Maintainer: Gabe Black <gabeblack@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/cpu/o3/cpu.cc
src/cpu/o3/deriv.cc