svga: Fix incorrect advertizing of EGL_KHR_gl_colorspace
authorThomas Hellstrom <thellstrom@vmware.com>
Thu, 12 Apr 2018 12:41:47 +0000 (14:41 +0200)
committerThomas Hellstrom <thellstrom@vmware.com>
Thu, 19 Apr 2018 11:42:51 +0000 (13:42 +0200)
commite0c08183fb20399128ff363467e00aa1e8767886
treee7bbcd191f704a11cd2a0bd5f3c070fa1476b10a
parent79487c427ee2f82bc947ac1dffd6e2374efaa90f
svga: Fix incorrect advertizing of EGL_KHR_gl_colorspace

When advertizing this extension, egl_dri2 uses the DRI2_RENDERER_QUERY
extension to query whether an sRGB format is supported. That extension will
query our driver with the BIND flag PIPE_BIND_RENDER_TARGET rather than
PIPE_BIND_DISPLAY_TARGET which is used when building the configs.
We only return the correct value for PIPE_BIND_DISPLAY_TARGET.

The inconsistency causes EGL to crash at surface initialization if sRGB is
not supported. Fix this by supporting both bind flags.

Testing done:
piglit egl_gl_colorspace srgb

Cc: <mesa-stable@lists.freedesktop.org>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Charmaine Lee <charmainel@vmware.com>
src/gallium/drivers/svga/svga_format.c