gdb: replace some calls to internal_error with gdb_assert
authorSimon Marchi <simon.marchi@polymtl.ca>
Thu, 2 Apr 2020 19:43:41 +0000 (15:43 -0400)
committerSimon Marchi <simon.marchi@polymtl.ca>
Thu, 2 Apr 2020 19:43:41 +0000 (15:43 -0400)
commite2ff18a0a54f98c38f8d9b80c36faa7aacacf6d6
tree5959139d65e073812e1623aad0c4547323758cb8
parent0830d301901d225403eaf6629c20a6c09f3ec8f6
gdb: replace some calls to internal_error with gdb_assert

There are a few spots using the pattern:

  if (condition)
    internal_error (__FILE__, __LINE__,
    _("failed internal consistency check"));

The message brings no value, since it's pretty the description of a
failed assertion.  Replace a few of these that are obvious with
gdb_assert.

gdb/ChangeLog:

* exec.c (build_section_table): Replace internal_error with
gdb_assert.
(section_table_xfer_memory_partial): Likewise.
* mdebugread.c (parse_partial_symbols): Likewise.
* psymtab.c (lookup_partial_symbol): Likewise.
* utils.c (wrap_here): Likewise.
gdb/ChangeLog
gdb/exec.c
gdb/mdebugread.c
gdb/psymtab.c
gdb/utils.c