i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'
authorAndrii Simiklit <andrii.simiklit@globallogic.com>
Wed, 12 Sep 2018 16:05:45 +0000 (19:05 +0300)
committerJordan Justen <jordan.l.justen@intel.com>
Tue, 30 Oct 2018 19:09:17 +0000 (12:09 -0700)
commite4e0fd5ffe1de9078ac8906155e1a80ca2006994
treeb7ef205ca124b24ba476295f382d390e6e438467
parenta9031bf9b55602d93cccef6c926e2179c23205b4
i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

If we restore the 'new batch' using 'intel_batchbuffer_reset_to_saved'
function we must restore the default state of the batch using
'brw_new_batch' function because the 'intel_batchbuffer_flush'
function will not do it for the 'new batch' again.
At least the following fields of the batch
'state_base_address_emitted','aperture_space', 'state_used'
should be restored to default values to avoid:
1. the aperture_space overflow
2. the missed STATE_BASE_ADDRESS commad in the batch
3. the memory overconsumption of the 'statebuffer'
   due to uncleared 'state_used' field.
etc.

v2: merge with new commits, changes was minimized, added the 'fixes' tag
v3: added in to patch series

Fixes: 3faf56ffbdeb "intel: Add an interface for saving/restoring
                     the batchbuffer state."
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107626
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i965/intel_batchbuffer.c