base: ELF segment types are not bitfields.
authorGabe Black <gabeblack@google.com>
Wed, 2 Oct 2019 02:26:12 +0000 (19:26 -0700)
committerGabe Black <gabeblack@google.com>
Sat, 5 Oct 2019 04:17:23 +0000 (04:17 +0000)
commite4ed0d84013a36dda19dd93d6b883d7d2984d600
treeeaa6b0727f949545856610075a5c6366d5168c93
parent2dc4b9d95a156030e9b7ac44ffbdbf9bdacc5944
base: ELF segment types are not bitfields.

The ELF segment type had been checked by bitwise &-ing it with the
PT_LOAD constant to check if it was loadable. This is incorrect. The
value is a flat integer, with different values selecting different
types of segments.

Change-Id: I644dd985bda4ad2d992557c90ffe8048c0ae6aac
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/21460
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Anthony Gutierrez <anthony.gutierrez@amd.com>
Maintainer: Anthony Gutierrez <anthony.gutierrez@amd.com>
src/base/loader/elf_object.cc