glsl: revert "glsl: atomic counters can be declared as buffer-qualified variables"
authorIago Toral Quiroga <itoral@igalia.com>
Mon, 28 Sep 2015 11:56:28 +0000 (13:56 +0200)
committerIago Toral Quiroga <itoral@igalia.com>
Mon, 28 Sep 2015 12:23:26 +0000 (14:23 +0200)
commite7ae6d9e141489281295352e43facbc1aeb137d9
tree6de089d6a35cefd75d3cf77351c6ee8e81e51751
parent5bff12ecb403356d7848dc02696c618b68a324f1
glsl: revert "glsl: atomic counters can be declared as buffer-qualified variables"

This reverts commit 586142658e2927a68c.

The specs are not explicit about any restrictions related to the types allowed
on buffer variables, however, the description of opaque types (like atomic
counters) is in conclict with the purpose of buffer variables:

"The opaque types declare variables that are effectively opaque
 handles to other objects. These objects are
 accessed through built-in functions, not through direct reading or
 writing of the declared variable.
 (...)
 Opaque variables cannot be treated as l-values;(...)"

Also, Mesa is already disallowing opaque types in interface blocks anyway, so
that commit was not really achieving anything.

Reviewed-by: Francisco Jerez <currojerez@riseup.net>
src/glsl/ast_to_hir.cpp