libctf: ctf_archive_next should set the parent name consistently
authorNick Alcock <nick.alcock@oracle.com>
Thu, 18 Feb 2021 16:56:23 +0000 (16:56 +0000)
committerNick Alcock <nick.alcock@oracle.com>
Tue, 2 Mar 2021 15:08:03 +0000 (15:08 +0000)
commiteaa2913a7acead8654e7e79ba13c0d22fd70a452
tree9c83d0400a69f9c4b3551f6b8c3b6f3c1e6f4af9
parentb80e421f9136117389be9d96210b35b3d562d725
libctf: ctf_archive_next should set the parent name consistently

The top level of CTF containers is a "CTF archive", which contains a
collection of named members (each a CTF dictionary).  In the serialized
file format, this is optional and skipped if the archive would have only
one member, as when no ambiguous types are present: so it is commonplace
to have a simple ctf_dict_t written out, with no archive container
wrapped around it.

But, unlike ctf_archive_iter, ctf_archive_next didn't quite handle this
case right.  It should set the name of this fake "member" to
_CTF_SECTION, i.e. ".ctf", but it was failing to do so, so callers got
an unintialized variable back instead and were understandably confused.

So set the name properly.

libctf/ChangeLog
2021-03-02  Nick Alcock  <nick.alcock@oracle.com>

* ctf-archive.c (ctf_archive_next): Set the name of parents in
single-member archives.
libctf/ChangeLog
libctf/ctf-archive.c