RISC-V: PR28509, the default visibility symbol cannot be referenced by R_RISCV_JAL.
authorNelson Chu <nelson@rivosinc.com>
Mon, 12 Sep 2022 01:26:52 +0000 (09:26 +0800)
committerNelson Chu <nelson@rivosinc.com>
Mon, 12 Sep 2022 03:31:41 +0000 (11:31 +0800)
commitecb915b4de7569027ad78bd3e24873bb92cb8e32
tree322bc83c90f3bf3b2be8c4b3d696dcaaf0d328d1
parent0967e2e4926f07de0ff0eabd16ea8965c63b9f2e
RISC-V: PR28509, the default visibility symbol cannot be referenced by R_RISCV_JAL.

When generating the shared object, the default visibility symbols may bind
externally, which means they will be exported to the dynamic symbol table,
and are preemptible by default.  These symbols cannot be referenced by the
non-pic R_RISCV_JAL and R_RISCV_RVC_JUMP.  However, consider that linker
may relax the R_RISCV_CALL relocations to R_RISCV_JAL or R_RISCV_RVC_JUMP,
if these relocations are relocated to the plt entries, then we won't report
error for them.  Perhaps we also need the similar checks for the
R_RISCV_BRANCH and R_RISCV_RVC_BRANCH relocations.

After applying this patch, and revert the following glibc patch,
riscv: Fix incorrect jal with HIDDEN_JUMPTARGET
https://sourceware.org/git/?p=glibc.git;a=commit;h=68389203832ab39dd0dbaabbc4059e7fff51c29b

I get the expected errors as follows,
ld: relocation R_RISCV_RVC_JUMP against `__sigsetjmp' which may bind externally can not be used when making a shared object; recompile with -fPIC
ld: relocation R_RISCV_JAL against `exit' which may bind externally can not be used when making a shared object; recompile with -fPIC

Besides, we also have similar changes for libgcc,
RISC-V: jal cannot refer to a default visibility symbol for shared object
https://github.com/gcc-mirror/gcc/commit/45116f342057b7facecd3d05c2091ce3a77eda59

bfd/
pr 28509
* elfnn-riscv.c (riscv_elf_relocate_section): Report errors when
makeing a shard object, and the referenced symbols of R_RISCV_JAL
relocations are default visibility.  Besides, we should handle most
of the cases here, so don't need the unresolvable check later for
R_RISCV_JAL and R_RISCV_RVC_JUMP.
ld/
pr 28509
* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated.
* testsuite/ld-riscv-elf/lib-nopic-01a.s: Removed.
* testsuite/ld-riscv-elf/lib-nopic-01b.d: Likewise.
* testsuite/ld-riscv-elf/lib-nopic-01b.s: Likewise.
* testsuite/ld-riscv-elf/shared-lib-nopic-01.d: New testcase.
* testsuite/ld-riscv-elf/shared-lib-nopic-01.s: Likewise.
* testsuite/ld-riscv-elf/shared-lib-nopic-02.d: Likewise.
* testsuite/ld-riscv-elf/shared-lib-nopic-02.s: Likewise.
* testsuite/ld-riscv-elf/shared-lib-nopic-03.d: Likewise.
* testsuite/ld-riscv-elf/shared-lib-nopic-03.s: Likewise.
* testsuite/ld-riscv-elf/shared-lib-nopic-04.d: Likewise.
* testsuite/ld-riscv-elf/shared-lib-nopic-04.s: Likewise.
13 files changed:
bfd/elfnn-riscv.c
ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
ld/testsuite/ld-riscv-elf/lib-nopic-01a.s [deleted file]
ld/testsuite/ld-riscv-elf/lib-nopic-01b.d [deleted file]
ld/testsuite/ld-riscv-elf/lib-nopic-01b.s [deleted file]
ld/testsuite/ld-riscv-elf/shared-lib-nopic-01.d [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/shared-lib-nopic-01.s [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/shared-lib-nopic-02.d [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/shared-lib-nopic-02.s [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/shared-lib-nopic-03.d [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/shared-lib-nopic-03.s [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/shared-lib-nopic-04.d [new file with mode: 0644]
ld/testsuite/ld-riscv-elf/shared-lib-nopic-04.s [new file with mode: 0644]