meson: remove dependency antipattern
authorEric Engestrom <eric.engestrom@intel.com>
Tue, 8 May 2018 15:40:24 +0000 (16:40 +0100)
committerEric Engestrom <eric.engestrom@intel.com>
Mon, 14 May 2018 13:55:36 +0000 (14:55 +0100)
commitf0cdc39b134dfc38f84b0f6dc1eaad86d28d4170
tree63d5b3ddbea96004a20203f91a30b98bd278604a
parentece398277cf1de5ac4debfd9855909fd1bafb239
meson: remove dependency antipattern

`dep_valgrind != []` now (0.45) produces a warning that is quite explicit:
  WARNING: Trying to compare values of different types (DependencyHolder, list) using !=.
  The result of this is undefined and will become a hard error in a future Meson release.

`dep_valgrind = []` used to be the recommended way to deal with
non-existant dependency, but these don't work with `.found()`, so now
the recommended way is to declare a impossible dependency, which
null_dep does for us in Mesa.

In short, we don't need and shouldn't check for `!= []` anywhere anymore.

Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
src/compiler/glsl/glcpp/meson.build