Test binutils_assemble return value
authorAlan Modra <amodra@gmail.com>
Fri, 15 Dec 2017 06:38:56 +0000 (17:08 +1030)
committerAlan Modra <amodra@gmail.com>
Mon, 18 Dec 2017 20:21:33 +0000 (06:51 +1030)
commitf795c49463234dc347ddd9a1b07ee5b506295b96
treee55a82360d64a55d45ed88ade2d1e9c4438ac470
parentc54207d32681bb205c28facba73b6173ef15eabf
Test binutils_assemble return value

This is a followup to "binutils nm testsuite tidy".  Since the perror
in binutils_assemble has been removed, we need to take more care in
failure paths.

The patch also fixed a number of .exp files that have multiple tests,
where an assembly failure returns from the .exp file.  In most cases
it is nicer to attempt all tests.

* testsuite/binutils-all/ar.exp (unique_symbol): Don't run AR
if assembly fails.
* testsuite/binutils-all/arc/objdump.exp (check_assembly): If
objfile is empty, fail test.
* testsuite/binutils-all/arm/objdump.exp: Don't return if assembly
fails for a test, continue on to other tests.
* testsuite/binutils-all/bfin/objdump.exp: Likewise.
* testsuite/binutils-all/hppa/objdump.exp: Likewise.
* testsuite/binutils-all/m68k/objdump.exp: Likewise.
* testsuite/binutils-all/vax/objdump.exp: Likewise.
* testsuite/binutils-all/size.exp: Likewise.
* testsuite/binutils-all/nm.exp: Likewise.  Move PR12753 test.
* testsuite/binutils-all/objcopy.exp: Don't perror on assembly fail.
* testsuite/binutils-all/objdump.exp: Report assembly fails.
12 files changed:
binutils/ChangeLog
binutils/testsuite/binutils-all/ar.exp
binutils/testsuite/binutils-all/arc/objdump.exp
binutils/testsuite/binutils-all/arm/objdump.exp
binutils/testsuite/binutils-all/bfin/objdump.exp
binutils/testsuite/binutils-all/hppa/objdump.exp
binutils/testsuite/binutils-all/m68k/objdump.exp
binutils/testsuite/binutils-all/nm.exp
binutils/testsuite/binutils-all/objcopy.exp
binutils/testsuite/binutils-all/objdump.exp
binutils/testsuite/binutils-all/size.exp
binutils/testsuite/binutils-all/vax/objdump.exp