gdb/testsuite/gdb.rocm: Check value returned by hipDeviceSynchronize
authorLancelot Six <lancelot.six@amd.com>
Tue, 17 Oct 2023 15:45:45 +0000 (15:45 +0000)
committerLancelot Six <lancelot.six@amd.com>
Wed, 18 Oct 2023 08:26:23 +0000 (08:26 +0000)
commitfded0fb898618b5b659762ace776144afa876035
tree204071443f2e22255a8f6f2cd193fd4269b63bcd
parent0f79aa900f3a69780dde1e934ffe21e30236934e
gdb/testsuite/gdb.rocm: Check value returned by hipDeviceSynchronize

Functions of the hip runtime returning a hipError_t can be marked
nodiscard depending on the configuration[1] (when compiled with C++17).

This patch makes sure that we always check the value returned by
hipDeviceSynchronize and friends, and print an error message when
appropriate.  This avoid a wall of warnings when running the testsuite
if the compiler defaults to using C++17.

It is always a good practice to check the return values anyway.

[1] https://github.com/ROCm-Developer-Tools/HIP/blob/docs/5.7.1/include/hip/hip_runtime_api.h#L203-L218

Change-Id: I2a819a8ac45f4bcf814efe9a2ff12c6a7ad22f97
Approved-By: Simon Marchi <simon.marchi@efficios.com>
gdb/testsuite/gdb.rocm/fork-exec-gpu-to-non-gpu-execer.cpp
gdb/testsuite/gdb.rocm/fork-exec-non-gpu-to-gpu-execee.cpp
gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp
gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.cpp
gdb/testsuite/gdb.rocm/precise-memory.cpp
gdb/testsuite/lib/rocm.exp