Fix diagnostic errors
authorAlan Modra <amodra@gmail.com>
Fri, 6 Jul 2018 05:37:08 +0000 (15:07 +0930)
committerAlan Modra <amodra@gmail.com>
Fri, 6 Jul 2018 05:48:59 +0000 (15:18 +0930)
commitfe75810f8e0cc33384f22d0479506711d4014c60
treed24b2e14f08d21666a173a16789e4ec5e28b7080
parent724436fccb68156ff53b7b03cb7f41547a65c30c
Fix diagnostic errors

Fixes a number of build errors like the following
.../elf32-arm.c: In function 'elf32_arm_nabi_write_core_note':
.../elf32-arm.c:2177: error: #pragma GCC diagnostic not allowed inside functions
.../elf32-arm.c:2186: error: #pragma GCC diagnostic not allowed inside functions
See the comment in diagnostics.h.

include/
* diagnostics.h: Comment on macro usage.
bfd/
* elf32-arm.c (elf32_arm_nabi_write_core_note): Don't use
DIAGNOTIC_PUSH and DIAGNOSTIC_POP unconditionally.
* elf32-ppc.c (ppc_elf_write_core_note): Likewise.
* elf32-s390.c (elf_s390_write_core_note): Likewise.
* elf64-ppc.c (ppc64_elf_write_core_note): Likewise.
* elf64-s390.c (elf_s390_write_core_note): Likewise.
* elfxx-aarch64.c (_bfd_aarch64_elf_write_core_note): Likewise.
bfd/ChangeLog
bfd/elf32-arm.c
bfd/elf32-ppc.c
bfd/elf32-s390.c
bfd/elf64-ppc.c
bfd/elf64-s390.c
bfd/elfxx-aarch64.c
include/ChangeLog
include/diagnostics.h