scons: fix unused auto-generated blob variable in clang
authorCiro Santilli <ciro.santilli@arm.com>
Sat, 26 Jan 2019 13:16:17 +0000 (13:16 +0000)
committerCiro Santilli <ciro.santilli@arm.com>
Wed, 6 Feb 2019 16:11:24 +0000 (16:11 +0000)
commitff5ad434d95403005cbf229a0f4b077b6dbc502b
tree97813e14a37dc472e0a3223e71c3e5cf7fd07ff5
parent930979744009b4cec970bb9e851cff3259c895b8
scons: fix unused auto-generated blob variable in clang

Since f2bda876f73af4ecc38406f3562a3d16fd28a5a9, the build system started
adding a length for generated blobs as in:

const std::size_t variable_len = 123;

There were two types of blob files, ones with a header and the ones
without.

The ones with the header, also include the header in the .cc of the blob,
which contains a declaration:

extern const std::size_t variable_len;

Therefore, the ones without header, don't have that extern declaration,
which makes them static according to the C++ standard.

clang then correctly interprets that as problematic due to
-Wunused-const-variable, while GCC does not notice this.

This patch removes the length declaration from the blob files that don't
have the header. Those files currently don't use the length.

Change-Id: I3fc61b28f887fc1015288857328ead2f3b34c6e6
Reviewed-on: https://gem5-review.googlesource.com/c/15955
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
src/SConscript