PR c++/24667
* typeck.c (check_for_casting_away_constness): Use the diag_fn.
(build_const_cast_1): Call it, for C-style casts.
PR c++/24667
* g++.dg/warn/Wcast-qual1.C: New test.
From-SVN: r107032
+2005-11-15 Mark Mitchell <mark@codesourcery.com>
+
+ PR c++/24667
+ * typeck.c (check_for_casting_away_constness): Use the diag_fn.
+ (build_const_cast_1): Call it, for C-style casts.
+
2005-11-14 Mark Mitchell <mark@codesourcery.com>
PR c++/24687
2005-11-14 Mark Mitchell <mark@codesourcery.com>
PR c++/24687
const char *description)
{
if (diag_fn && casts_away_constness (src_type, dest_type))
const char *description)
{
if (diag_fn && casts_away_constness (src_type, dest_type))
- error ("%s from type %qT to type %qT casts away constness",
- description, src_type, dest_type);
+ diag_fn ("%s from type %qT to type %qT casts away constness",
+ description, src_type, dest_type);
}
/* Convert EXPR (an expression with pointer-to-member type) to TYPE
}
/* Convert EXPR (an expression with pointer-to-member type) to TYPE
/* Perform a const_cast from EXPR to TYPE. If the cast is valid,
return an appropriate expression. Otherwise, return
error_mark_node. If the cast is not valid, and COMPLAIN is true,
/* Perform a const_cast from EXPR to TYPE. If the cast is valid,
return an appropriate expression. Otherwise, return
error_mark_node. If the cast is not valid, and COMPLAIN is true,
- then a diagnostic will be issued. If VALID_P is non-NULL, its
- value upon return will indicate whether or not the conversion
- succeeded. */
+ then a diagnostic will be issued. If VALID_P is non-NULL, we are
+ performing a C-style cast, its value upon return will indicate
+ whether or not the conversion succeeded. */
static tree
build_const_cast_1 (tree dst_type, tree expr, bool complain,
static tree
build_const_cast_1 (tree dst_type, tree expr, bool complain,
&& comp_ptr_ttypes_const (dst_type, src_type))
{
if (valid_p)
&& comp_ptr_ttypes_const (dst_type, src_type))
{
if (valid_p)
+ {
+ *valid_p = true;
+ /* This cast is actually a C-style cast. Issue a warning if
+ the user is making a potentially unsafe cast. */
+ if (warn_cast_qual)
+ check_for_casting_away_constness (src_type, dst_type,
+ warning0,
+ "cast");
+ }
if (reference_type)
{
expr = build_unary_op (ADDR_EXPR, expr, 0);
if (reference_type)
{
expr = build_unary_op (ADDR_EXPR, expr, 0);
+2005-11-15 Mark Mitchell <mark@codesourcery.com>
+
+ PR c++/24667
+ * g++.dg/warn/Wcast-qual1.C: New test.
+
2005-11-15 Jan Hubicka <jh@suse.cz>
* gcc.dg/winline-5.c: Add large-unit-insns limit.
2005-11-15 Jan Hubicka <jh@suse.cz>
* gcc.dg/winline-5.c: Add large-unit-insns limit.
--- /dev/null
+// PR c++/24667
+// { dg-options "-Wcast-qual" }
+
+int main(int, char**) {
+ const int foo[2] = {1,1};
+ ((int*)foo)[0] = 0; // { dg-warning "cast" }
+}