PR22166, SHT_GNU_verneed memory allocation

The sanity check covers the previous minimim size, plus that the size
is at least enough for sh_info verneed entries.

Also, since we write all verneed fields or exit with an error, there
isn't any need to zero the memory allocated for verneed entries.

	PR 22166
	* elf.c (_bfd_elf_slurp_version_tables): Test sh_info on
	SHT_GNU_verneed section for sanity.  Don't zalloc memory for
	verref.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 9b4cb08d14e8347b76386527aba23b4844123433..af04da9e69ea8954e32895939692fd2e69259de2 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2017-09-24  Alan Modra  <amodra@gmail.com>
+
+       PR 22166
+       * elf.c (_bfd_elf_slurp_version_tables): Test sh_info on
+       SHT_GNU_verneed section for sanity.  Don't zalloc memory for
+       verref.
+

 2017-09-22  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR binutils/22170
 2017-09-22  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR binutils/22170

diff --git a/bfd/elf.c b/bfd/elf.c
index 9b61f06a84c9b5c5783bab86b64bd289b8f86496..38dba485003af1572fe6a17bd1668b883da9881a 100644 (file)
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -8198,7 +8198,8 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bfd_boolean default_imported_symver)
 
       hdr = &elf_tdata (abfd)->dynverref_hdr;
 
 
       hdr = &elf_tdata (abfd)->dynverref_hdr;
 

-      if (hdr->sh_info == 0 || hdr->sh_size < sizeof (Elf_External_Verneed))
+      if (hdr->sh_info == 0
+         || hdr->sh_info > hdr->sh_size / sizeof (Elf_External_Verneed))

        {
 error_return_bad_verref:
          _bfd_error_handler
        {
 error_return_bad_verref:
          _bfd_error_handler


@@ -8219,7 +8220,7 @@ error_return_verref:
        goto error_return_verref;
 
       elf_tdata (abfd)->verref = (Elf_Internal_Verneed *)
        goto error_return_verref;
 
       elf_tdata (abfd)->verref = (Elf_Internal_Verneed *)

-       bfd_zalloc2 (abfd, hdr->sh_info, sizeof (Elf_Internal_Verneed));
+       bfd_alloc2 (abfd, hdr->sh_info, sizeof (Elf_Internal_Verneed));

 
       if (elf_tdata (abfd)->verref == NULL)
        goto error_return_verref;
 
       if (elf_tdata (abfd)->verref == NULL)
        goto error_return_verref;